Conversation
|
This is just an early in progress , commit. It almost works, but a decision has to be made about how the specs are bundled , one quirk of what we currently have is that the dereferenced spec needs to be used everywhere, the spec bundled right now is reff'd to keep the spec smaller, the easiest thing is to just shuffle around derefferenced spec. Another thing here is that we might just cascade deps, and include the spec in the types that generated them. Spec types will need to do this for golang to maintain the old behavior, so it's possible that we just package them both up again where it's types plus generative spec it's not a terrible idea imho. Just needs to be decided probably the safest is to not have multiple packages using different versions of the dereffer potentially having multiple schemas float so it should probably propagate from the spec. If from the spec, it's derefferenced once and we can also have potentially better eyes on it and we know exactly what went into the sauce to make everything work downstream. The only downside is size, which is only a downside on web, and maybe IOT , but probably less so these days. |
615f7c6 to
27e5af9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
===========================================
- Coverage 100.00% 99.81% -0.19%
===========================================
Files 16 17 +1
Lines 531 539 +8
Branches 137 141 +4
===========================================
+ Hits 531 538 +7
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
27e5af9 to
5aad757
Compare
This officially formally supports being able to validate specific versions for of an open-rpc document. Previously we had a sort of catchall for all documents, now we have a formal system for validating specific versions. This means we have a pathway forward for larger changes to occur in the ecosystem while maintaining reliability.
7207204 to
6df92b2
Compare
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.