Skip to content

Feat/spec types#976

Merged
zcstarr merged 2 commits intomasterfrom
feat/spec-types
Feb 25, 2026
Merged

Feat/spec types#976
zcstarr merged 2 commits intomasterfrom
feat/spec-types

Conversation

@zcstarr
Copy link
Member

@zcstarr zcstarr commented Feb 14, 2026

No description provided.

@zcstarr
Copy link
Member Author

zcstarr commented Feb 14, 2026

This is just an early in progress , commit. It almost works, but a decision has to be made about how the specs are bundled , one quirk of what we currently have is that the dereferenced spec needs to be used everywhere, the spec bundled right now is reff'd to keep the spec smaller, the easiest thing is to just shuffle around derefferenced spec.

Another thing here is that we might just cascade deps, and include the spec in the types that generated them. Spec types will need to do this for golang to maintain the old behavior, so it's possible that we just package them both up again where it's types plus generative spec it's not a terrible idea imho.

Just needs to be decided probably the safest is to not have multiple packages using different versions of the dereffer potentially having multiple schemas float so it should probably propagate from the spec. If from the spec, it's derefferenced once and we can also have potentially better eyes on it and we know exactly what went into the sauce to make everything work downstream. The only downside is size, which is only a downside on web, and maybe IOT , but probably less so these days.

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.81%. Comparing base (5ff0ae0) to head (6df92b2).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##            master     #976      +/-   ##
===========================================
- Coverage   100.00%   99.81%   -0.19%     
===========================================
  Files           16       17       +1     
  Lines          531      539       +8     
  Branches       137      141       +4     
===========================================
+ Hits           531      538       +7     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This officially formally supports being able to validate specific
versions for of an open-rpc document.

Previously we had a sort of catchall for all documents, now
we have a formal system for validating specific versions. This
means we have a pathway forward for larger changes to occur
in the ecosystem while maintaining reliability.
@zcstarr zcstarr merged commit c208653 into master Feb 25, 2026
3 of 4 checks passed
@BelfordZ
Copy link
Member

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants